[spark] use CamelCase in config names#3471
Open
fresh-borzoni wants to merge 1 commit into
Open
Conversation
Member
Author
|
@Yohahaha @YannByron @luoyuxia PTAL 🙏 |
Yohahaha
reviewed
Jul 1, 2026
Yohahaha
left a comment
Yohahaha
left a comment
Contributor
There was a problem hiding this comment.
Sorry for the late reply.
I think we should keep the current dot-style configuration. For longer configuration names, use camelCase. for scan.maxRecordsPerPartition, scan represents the configuration module, and maxRecordsPerPartition represents a specific setting within the scan module. This naming convention is also used in Spark, for example spark.sql.optimizer.xxx
|
|
||
| val SCAN_POLL_TIMEOUT: ConfigOption[Duration] = | ||
| ConfigBuilder | ||
| .key("scan.poll.timeout") |
Contributor
|
One small question: the deprecation path — is there a plan to keep the old snake_case names working with |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #3462
making SparkConfig consistent